Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate memory_limit check to new SetupCheck API #41086

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Migrate memory_limit check to new SetupCheck API #41086

merged 1 commit into from
Nov 14, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Oct 24, 2023 •
edited
Loading

Summary

Migrate memory_limit check to new SetupCheck API

Checklist

@come-nc come-nc self-assigned this Oct 24, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 24, 2023
View reviewed changes
apps/settings/lib/Controller/CheckSetupController.php Outdated
ITempManager $tempManager,
IManager $manager,
IAppManager $appManager,
IServerContainer $serverContainer,

Check notice

Code scanning / Psalm

DeprecatedInterface Note

Interface OCP\IServerContainer is marked as deprecated
@come-nc come-nc force-pushed the feat/migrate-memory-limit-setup-check branch from e3b2532 to 6853146 Compare October 24, 2023 13:34
@come-nc come-nc added the 2. developing Work in progress label Oct 26, 2023
@come-nc come-nc added this to the Nextcloud 28 milestone Oct 26, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
@come-nc come-nc force-pushed the feat/migrate-memory-limit-setup-check branch from 6853146 to e7f3ea9 Compare November 7, 2023 09:00
@come-nc come-nc marked this pull request as ready for review November 7, 2023 09:08
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 7, 2023
@come-nc come-nc mentioned this pull request Nov 9, 2023
Closed
33 tasks
@come-nc come-nc force-pushed the feat/migrate-memory-limit-setup-check branch from e7f3ea9 to 4943f88 Compare November 9, 2023 15:31
@blizzz blizzz mentioned this pull request Nov 10, 2023
Merged
@come-nc come-nc force-pushed the feat/migrate-memory-limit-setup-check branch from 4943f88 to 5be166a Compare November 13, 2023 14:13
@come-nc come-nc requested review from a team, ArtificialOwl, Altahrim and nfebe and removed request for a team November 13, 2023 14:14
@come-nc
Migrate memory_limit check to new SetupCheck API
7495236 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the feat/migrate-memory-limit-setup-check branch from 5be166a to 7495236 Compare November 13, 2023 14:56
@come-nc come-nc requested a review from Altahrim November 13, 2023 14:56
@come-nc come-nc merged commit 70acf44 into master Nov 14, 2023
48 of 50 checks passed
@come-nc come-nc deleted the feat/migrate-memory-limit-setup-check branch November 14, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Altahrim Altahrim Altahrim approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @AndyScherzinger @Altahrim