-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize UserMountCache::registerStorage #41057
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
blizzz,
Altahrim and
Fenn-CS
and removed request for
a team
October 23, 2023 11:33
Merged
Merged
icewind1991
force-pushed
the
registermounts-opt
branch
from
November 9, 2023 14:36
8e93901
to
f6f6d74
Compare
Merged
blizzz
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing required annotation, otherwise 👍
Merged
Altahrim
force-pushed
the
registermounts-opt
branch
from
November 16, 2023 10:35
f6f6d74
to
51868d7
Compare
blizzz
approved these changes
Nov 16, 2023
juliushaertl
approved these changes
Nov 16, 2023
juliushaertl
requested changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah wait CI shows some issue:
PHP Fatal error: Nesting level too deep - recursive dependency? in /home/runner/work/server/server/lib/private/Files/Config/UserMountCache.php on line 130
Altahrim
force-pushed
the
registermounts-opt
branch
from
November 16, 2023 15:06
631b839
to
feb8ff6
Compare
Altahrim
force-pushed
the
registermounts-opt
branch
from
November 16, 2023 15:19
feb8ff6
to
7a2d994
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
registermounts-opt
branch
from
November 16, 2023 15:22
7a2d994
to
b942850
Compare
juliushaertl
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the logic a bit and use less intermediate arrays