fix(session): Log critical conditions where sessions might be lost #40878
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
3. to review
|
/backport to stable27 |
ChristophWurst
force-pushed
the
fix/session/log-likely-lost-session-conditions
branch
from
736a5f9
to
37367ec
Compare
juliushaertl
approved these changes
Oct 11, 2023
ChristophWurst
force-pushed
the
fix/session/log-likely-lost-session-conditions
branch
from
37367ec
to
44196bb
Compare
blizzz
approved these changes
Oct 12, 2023
|
CI having opinions |
nickvergessen
approved these changes
Oct 12, 2023
* Regenerating session when cookies can't be sent -> lost * Regenerating session ID and deleting old data -> possible loss Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/session/log-likely-lost-session-conditions
branch
from
44196bb
to
95a14f2
Compare
ChristophWurst
commented
Oct 13, 2023
| 'deleteOldSession' => $deleteOldSession, | ||
| ]); | ||
| } elseif ($deleteOldSession) { | ||
| logger('core')->warning('Calling session_regenerate_id with delete_old_session=true can lead to lost sessions'); |
There was a problem hiding this comment.
should be lowered to debug. this is called a lot
Merged
Merged
ChristophWurst
added
1. to develop
skjnldsv
added
2. developing
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://www.php.net/manual/en/function.session-regenerate-id.php
Inspiration taken from https://github.com/symfony/symfony/blob/732ef5761c6576102983c99aab4a38679adce8d2/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php#L207-L229 too.
Checklist