fix(scheduling): don't send iMIP emails to rooms / resources #40876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
bug
3. to review
miaulalala
requested review from
a team,
Altahrim,
icewind1991 and
nfebe
and removed request for
a team
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tcitworld
requested changes
Oct 11, 2023
tcitworld
approved these changes
Oct 12, 2023
|
Re: #40876 (comment) |
You are checking the parameter object, not its value. |
Merged
miaulalala
force-pushed
the
fix/dont-send-imip-emails-to-rooms-resources
branch
3 times, most recently
from
70cb1f9 to
f05e67b
Compare
|
Failing tests are integration-sharees and interation-tags. Both ran out of time (1:00:00). |
blizzz
approved these changes
Nov 6, 2023
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/dont-send-imip-emails-to-rooms-resources
branch
from
f05e67b to
a75173a
Compare
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current iMIP plugin doesn't check for the CU type of the attendee and sends an invitation regardless.
Checklist
Screenshots before/after for front-end changesDocumentation (manuals or wiki) has been updated or is not required