Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented May 25, 2023

This reverts commit cb852ef

"Manager" column was wrong implemented, you can see it via editing rows:

Screenshot from 2023-05-25 11-55-12

But this is not a regression of cb852ef

Summary

Before After
Screenshot from 2023-05-24 17-41-23 Screenshot from 2023-05-25 11-52-23

Checklist

This reverts commit cb852ef

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@szaimen
Copy link
Contributor

szaimen commented May 25, 2023

Shouldnt these be exaclty the inversed numbers?
image
image
(from #37870)

@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented May 25, 2023

Shouldnt these be exaclty the inversed numbers?
image image
(from #37870)

there were added some things like "manager" column

@szaimen
Copy link
Contributor

szaimen commented May 25, 2023

there were added some things like "manager" column

I see. shouldnt we keep the manager column?

@ChristophWurst
Copy link
Member

I still see the manager code. @szaimen could you please give this a test? thanks

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work fine in my smoke testing

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks gut

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish regression and removed 3. to review Waiting for reviews labels May 25, 2023
@ChristophWurst
Copy link
Member

/backport to stable27

@JuliaKirschenheuter JuliaKirschenheuter merged commit 3d36420 into master May 25, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the revert/37870-Fix_table_view branch May 25, 2023 13:26
@ChristophWurst
Copy link
Member

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin/stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ChristophWurst
Copy link
Member

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin/stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ChristophWurst
Copy link
Member

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants