Skip to content

Check if version entity is not null before delete #38125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

Check if version entity is not null before delete #38125

merged 1 commit into from
May 9, 2023

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented May 8, 2023 •
edited
Loading

Summary

Check if version entity is not null before delete. This variable is being set in the array_filter() function, but it is possible that it remains empty if the function doesn't find any version that matches the conditions.

Checklist

@solracsf
Check if version entity is not null before delete
7cd5cbe 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added the 3. to review Waiting for reviews label May 8, 2023
@solracsf solracsf added this to the Nextcloud 27 milestone May 8, 2023
@solracsf solracsf requested a review from artonge May 8, 2023 12:26
@solracsf solracsf mentioned this pull request May 8, 2023
Closed
9 tasks
@solracsf
Copy link
Member Author

solracsf commented May 8, 2023

/backport to stable26

This was referenced May 9, 2023
Closed
Merged
artonge
artonge approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@artonge artonge requested review from a team, ArtificialOwl, come-nc, icewind1991 and nfebe and removed request for a team May 9, 2023 09:55
@skjnldsv skjnldsv merged commit 416f632 into master May 9, 2023
@skjnldsv skjnldsv deleted the versionEntityCheck branch May 9, 2023 15:11
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 9, 2023
Merged
@solracsf solracsf mentioned this pull request May 12, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

[Bug]: TypeError: OCP\AppFramework\Db\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\AppFramework\Db\Entity, null given

5 participants

@solracsf @artonge @skjnldsv @Pytal