Use a Generator for users in searchInGroups, type it as iterable #38026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Merged
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
enh/use-iterable-for-searchingroup
branch
from
6659f28
to
8a8355a
Compare
come-nc
commented
May 9, 2023
| @@ -380,11 +385,9 @@ public function searchInGroup(string $gid, string $search = '', int $limit = -1, | |||
| $users = []; | |||
| $userManager = \OCP\Server::get(IUserManager::class); | |||
| while ($row = $result->fetch()) { | |||
| $users[$row['uid']] = new LazyUser($row['uid'], $userManager, $row['displayname'] ?? null); | |||
| yield $row['uid'] => new LazyUser($row['uid'], $userManager, $row['displayname'] ?? null); | |||
| } | |||
| $result->closeCursor(); | |||
There was a problem hiding this comment.
This will not get called if the Generator is not exhausted by the caller, so this approach may be problematic.
Anyone have a better idea on how to do that?
|
Abandoning this, not enough time to try it out and see if it helps, and find a way to fix the cursor close problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since this is a new method in 27 it’s the occasion to make use of a generator instead of an array
Checklist