-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Skip registering mount points for missing owner node #37736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root problem is in the move logic no, it should somehow update the share info?
Signed-off-by: Julius Härtl <jus@bitgrid.net>
f178269
to
8c6703f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty expensive operation to perform for each incoming share and will kill performance for users with a large number of incoming shares.
It's probably better to catch this error when the user tries to interact with the broken. That way it doesn't have to run this check for N shares |
I lack time to finish this, so I'll close for now. We can reopen anyways if we need. |
Make sure that we don't show share mount points where the owner node is not available anymore.
steps to reproduce:
🛑 the shared file is still shown but user1 cannot access the file anymore
This still leaves an orphaned share entry but so far I had no luck finding a proper sql query so that we could add this to
server/apps/files_sharing/lib/DeleteOrphanedSharesJob.php
Line 33 in a0f6a65