Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(checkers): Require composer autoloaders for all shipped apps #37481

Merged
merged 1 commit into from
Aug 1, 2023
Merged

ci(checkers): Require composer autoloaders for all shipped apps #37481

merged 1 commit into from
Aug 1, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 30, 2023 •
edited
Loading

  • Resolves: #

Summary

We recently had some shipped apps without autoloader files. Let's add a CI check to enforce the file for all apps in this repo.

TODO

Checklist

@ChristophWurst ChristophWurst added the 1. to develop Accepted and waiting to be taken care of label Mar 30, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 27 milestone Mar 30, 2023
@ChristophWurst ChristophWurst self-assigned this Mar 30, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@ChristophWurst ChristophWurst force-pushed the ci/checkers/require-autoloader-shipped-apps branch from cdc47f6 to ee71151 Compare May 16, 2023 05:43
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels May 16, 2023
@ChristophWurst ChristophWurst marked this pull request as ready for review May 16, 2023 05:44
@ChristophWurst ChristophWurst requested review from a team, ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team May 16, 2023 05:44
@ChristophWurst
Copy link
Member Author

🏓 for review

@ChristophWurst
ci(checkers): Require composer autoloaders for all shipped apps
821ad80 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the ci/checkers/require-autoloader-shipped-apps branch from ee71151 to 821ad80 Compare July 24, 2023 11:58
@nickvergessen nickvergessen merged commit 9241a38 into master Aug 1, 2023
37 of 39 checks passed
@nickvergessen nickvergessen deleted the ci/checkers/require-autoloader-shipped-apps branch August 1, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
6 participants
@ChristophWurst @icewind1991 @AndyScherzinger @Fenn-CS @nickvergessen @skjnldsv