fix(provisioning_api): Don't allow to configure the same additional e… #37385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
ArtificialOwl and
icewind1991
and removed request for
a team
max-nextcloud
approved these changes
Apr 26, 2023
|
I wonder if one could alter the email address in ways that create a different string but still result in the same email address: |
juliushaertl
approved these changes
Apr 26, 2023
…mail multiple times Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/dont-allow-adding-the-same-email-multiple-times
branch
from
d90374c
to
1c0aae9
Compare
|
Can not reproduce the CI failure locally, so rebased to see if that solves it |
|
Okay, tests are not isolated in server. executing the full file makes it fail, so fixing now |
The integration tests are not isolated, so we can not reuse previously used data Signed-off-by: Joas Schilling <coding@schilljs.com>
Merged
nickvergessen
deleted the
bugfix/noid/dont-allow-adding-the-same-email-multiple-times
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mail multiple times
Editing one of the duplicated entries removed duplicates
Checklist