Revert "fix(performance): Do not set up filesystem on every call" #36788
Conversation
nickvergessen
commented
Feb 21, 2023
nickvergessen
commented
- Reverts fix(performance): Do not set up filesystem on every call #36589
- Details in Regression in filesystem handling breaks Talk/ attachment folder #36787
nickvergessen
added
bug
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @throws ServiceUnavailable | ||
| */ | ||
| private function createFileChunked($data) { | ||
| [$path, $name] = \Sabre\Uri\split($this->path); |
Check notice
Code scanning / Psalm
UndefinedFunction
|
|
||
| if ($chunk_handler->isComplete()) { | ||
| /** @var Storage $storage */ | ||
| [$storage,] = $this->fileView->resolvePath($path); |
Check notice
Code scanning / Psalm
DeprecatedClass
| if (isset($this->request->server['HTTP_OC_CHECKSUM'])) { | ||
| $checksum = trim($this->request->server['HTTP_OC_CHECKSUM']); | ||
| $this->fileView->putFileInfo($targetPath, ['checksum' => $checksum]); | ||
| } elseif ($info->getChecksum() !== null && $info->getChecksum() !== '') { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType
| if (isset($this->request->server['HTTP_OC_CHECKSUM'])) { | ||
| $checksum = trim($this->request->server['HTTP_OC_CHECKSUM']); | ||
| $this->fileView->putFileInfo($targetPath, ['checksum' => $checksum]); | ||
| } elseif ($info->getChecksum() !== null && $info->getChecksum() !== '') { |
Check notice
Code scanning / Psalm
PossiblyFalseReference
|
|
||
| $this->fileView->unlockFile($targetPath, ILockingProvider::LOCK_SHARED); | ||
|
|
||
| return $info->getEtag(); |
Check notice
Code scanning / Psalm
PossiblyFalseReference
| * @throws \Sabre\DAV\Exception\BadRequest | ||
| */ | ||
| public function sendFileIdHeader($filePath, \Sabre\DAV\INode $node = null) { | ||
| // chunked upload handling | ||
| if (isset($_SERVER['HTTP_OC_CHUNKED'])) { | ||
| [$path, $name] = \Sabre\Uri\split($filePath); |
Check notice
Code scanning / Psalm
UndefinedFunction
| private function resolveChunkFile($path) { | ||
| if (isset($_SERVER['HTTP_OC_CHUNKED'])) { | ||
| // resolve to real file name to find the proper node | ||
| [$dir, $name] = \Sabre\Uri\split($path); |
Check notice
Code scanning / Psalm
UndefinedFunction
| throw new InsufficientStorage("Insufficient space in $path, $length required, $freeSpace available"); | ||
| } | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| public function getFileChunking($info) { |
Check notice
Code scanning / Psalm
MissingReturnType
| throw new InsufficientStorage("Insufficient space in $path, $length required, $freeSpace available"); | ||
| } | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| public function getFileChunking($info) { |
Check notice
Code scanning / Psalm
MissingParamType
