add option to disable db user creation trough environment variable #36428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
come-nc
and removed request for
a team
come-nc
approved these changes
Jan 30, 2023
Merged
juliusknorr
reviewed
Feb 20, 2023
juliusknorr
approved these changes
Feb 20, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
disable-db-user-create
branch
from
b45aa1f to
b923310
Compare
icewind1991
added
4. to release
Merged
|
This was not documented, was it? |
szaimen
added
the
pending documentation
Indeed. Created tracker in docs repo for the time being: nextcloud/documentation#11858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When providing root/superuser db credentials, instead of using them as-is Nextcloud uses them to create a new non-root/superuser user.
While this can be useful to protect admins against accidentally running with elevated db access, this also interferes with some setup mechanisms that want more control over what db user is used. Currently the only option for these systems is to patch out the behavior themselves (see for NixOs for example).
This adds a way to disable this behavior by setting the
setup_create_db_userconfig variable tofalse, this can also be done trough an environment variable (NC_setup_create_db_user=false) for the setup command.