clear encrypted flag when moving away from encrypted storage#35961
Merged
clear encrypted flag when moving away from encrypted storage#35961
Conversation
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
come-nc
and removed request for
a team
come-nc
reviewed
Jan 3, 2023
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Code looks fine.
Is it possible to add tests for it?
Member
|
/backport to stable25 |
Member
|
/backport to stable24 |
Merged
icewind1991
force-pushed
the
move-from-encryption-remove-flag
branch
2 times, most recently
from
8692073 to
b4c810e
Compare
Merged
Merged
icewind1991
force-pushed
the
move-from-encryption-remove-flag
branch
2 times, most recently
from
b1bd148 to
5274f39
Compare
come-nc
approved these changes
Mar 27, 2023
Member
|
test failure unrelated, merge ? @come-nc @szaimen @icewind1991 |
Contributor
|
Lets rebase and merge :) |
Contributor
|
/rebase |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
nextcloud-command
force-pushed
the
move-from-encryption-remove-flag
branch
from
5274f39 to
808a80e
Compare
Contributor
|
/backport to stable26 |
This was referenced Apr 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When moving a file from an encrypted storage to a non-encrypted storage, the
encryptedflag isn't cleared currently.This usually isn't a problem since the
encryptedflag isn't checked when encrypted isn't enabled on a storage.However, when encryption is then enabled for the storage after files have been moved into them, the encryption wrapper will check the
encryptedflag, try to decrypt it, and fail.To test
occ config:app:set groupfolders enable_encryption --value true