Put Mimeloader insertion and read in the same transaction #35744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
requested review from
PVince81,
icewind1991 and
come-nc
and removed request for
a team
tcitworld
commented
Dec 13, 2022
tcitworld
force-pushed
the
mimeloader-transaction
branch
2 times, most recently
from
b655e41
to
532ace6
Compare
come-nc
reviewed
Dec 13, 2022
come-nc
reviewed
Dec 13, 2022
come-nc
reviewed
Dec 13, 2022
tcitworld
force-pushed
the
mimeloader-transaction
branch
from
532ace6
to
e6c7d64
Compare
come-nc
approved these changes
Dec 15, 2022
tcitworld
force-pushed
the
mimeloader-transaction
branch
from
e6c7d64
to
de3fb63
Compare
tcitworld
force-pushed
the
mimeloader-transaction
branch
from
de3fb63
to
d69f74e
Compare
tcitworld
force-pushed
the
mimeloader-transaction
branch
from
d69f74e
to
63088ce
Compare
|
Lint issues sound unrelated. |
tcitworld
force-pushed
the
mimeloader-transaction
branch
from
63088ce
to
18130ab
Compare
Comment on lines
-111
to
+116
| * @param int inserted ID | ||
| * @return int inserted ID |
nickvergessen
approved these changes
Jan 23, 2023
|
Might have a negative performance impact, but no clue |
Merged
Merged
Merged
|
/rebase |
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
nextcloud-command
force-pushed
the
mimeloader-transaction
branch
from
18130ab
to
036cd47
Compare
come-nc
reviewed
May 4, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And modernize code a bit.
Checklist