Skip to content

Fix background theming deletion and cypress admin theming tests #35728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2023
Merged

Fix background theming deletion and cypress admin theming tests #35728

merged 3 commits into from
Oct 19, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 11, 2022 •
edited
Loading

Leftover from #35666...
Restore cypress proper testing specs... 😮‍💨

  • Also added a new test to increase coverage
  • Fixed other found issues regarding user defaults not following the instance background if removed
  • Adjusted some more testing
  • Fixed proper cleanup of admin settings when undoing an image setting

Follwup:

  • Found some issues regarding how we override the #0082c9 colour with accessibility colour #006aa3.
    Will clarify with design team afterwards

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Dec 11, 2022
@skjnldsv skjnldsv added this to the Nextcloud 26 milestone Dec 11, 2022
@skjnldsv skjnldsv requested a review from a team December 11, 2022 11:07
@skjnldsv skjnldsv self-assigned this Dec 11, 2022
@skjnldsv skjnldsv requested review from PVince81, Pytal and artonge and removed request for a team December 11, 2022 11:07
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv

This comment was marked as resolved.

Sign in to view
skjnldsv
skjnldsv commented Dec 11, 2022
View reviewed changes
skjnldsv
skjnldsv commented Dec 11, 2022
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2022
View reviewed changes
skjnldsv
skjnldsv commented Dec 11, 2022
View reviewed changes
@skjnldsv skjnldsv changed the title Remove only cypress test selector leftover Fix background theming deletion and cypress admin theming tests Dec 11, 2022
@skjnldsv skjnldsv force-pushed the fix/cypress branch 2 times, most recently from 89911b4 to b28d97f Compare December 11, 2022 18:18
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 11, 2022
@PVince81
Copy link
Member

cypress failure ? or needs rebase / restart ?

@skjnldsv
Copy link
Member Author

cypress failure ? or needs rebase / restart ?

Need me to find time to dive into this again 🙈
image

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 13, 2023

@skjnldsv is this still relevant?

@skjnldsv
Copy link
Member Author

Yes we should but I don't have time for this unfortunately :/

@skjnldsv skjnldsv mentioned this pull request May 3, 2023
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 3, 2023
@skjnldsv skjnldsv force-pushed the fix/cypress branch 2 times, most recently from 79de33f to 7d257eb Compare July 6, 2023 19:44
@skjnldsv skjnldsv removed this from the Nextcloud 28 milestone Sep 2, 2023
@skjnldsv
Add additional no-background and custom colour test
d10c4c3 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Fix background removal check
a024ee1 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Fix background removal not applying to user default theming
4f40744 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Oct 19, 2023
@skjnldsv skjnldsv merged commit 049804d into master Oct 19, 2023
@skjnldsv skjnldsv deleted the fix/cypress branch October 19, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug regression

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv @PVince81 @szaimen @artonge @blizzz