Replace getSystemValue in encryption app #35590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
PVince81,
a team,
juliushaertl and
skjnldsv
and removed request for
a team
juliushaertl
approved these changes
Dec 5, 2022
|
@J0WI Seems the tests need some adjustments still :) |
J0WI
force-pushed
the
encryption.getsysvalue
branch
from
6256391
to
045ca0d
Compare
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
J0WI
force-pushed
the
encryption.getsysvalue
branch
from
045ca0d
to
71e4900
Compare
skjnldsv
approved these changes
Dec 6, 2022
come-nc
approved these changes
Dec 6, 2022
|
Failures unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Getting rid off some more
getSystemValue(), see ##35581 for context.Checklist