Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bootstrap from 4.6.1 to 5.2.3 #35567

Closed
wants to merge 1 commit into from
Closed

Bump bootstrap from 4.6.1 to 5.2.3 #35567

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 3, 2022 •
edited
Loading

Bumps bootstrap from 4.6.1 to 5.2.3.

Release notes

Sourced from bootstrap's releases.

v5.2.3

Fixes

🎨 CSS

  • #37377: Import root in bootstrap-utilities
  • #37425: Fix deprecation warning with sass 1.56.0
  • Carousel: Fix RTL translate() direction

☕️ JavaScript

  • #37235: fix tooltip/popper disposal inconsistencies

v5.2.2

Highlights

  • Accordion
    • Use Sass variable for the accordion color instead of an invalid CSS variable
  • Buttons
    • Undo changes to .btn:hover from v5.2.1. We now explicitly target .btn-check styles instead.
  • Dropdowns
    • Temporarily restore ability for dropdowns to work without an explicit data attribute (will be removed again in v6)
  • Modals
    • Improve modal event listeners
    • Use <h1> for all .modal-title instances in our docs
  • Tables
    • Don't redefine $border-color in table-variant() mixin
  • Tabs
    • Tabs no longer autofocus and cause pages to jump on tab.show()
    • Fix .active class toggling of tabs within dropdowns
  • Toasts
    • Properly set toast z-index on .toast-container as opposed to individual .toasts that don't receive any other positioning
  • Tooltips
    • Fix tooltip selectors with title attribute on dynamically created elements

🎨 CSS

  • #37118: Set toast z-index variable in the correct spot
  • #37165: Explicitly target .btn-check and undo :hover
  • #37182: Use Sass variable for accordion color
  • #37239: Don't redefine $border-color in table-variant mixin

☕️ JavaScript

  • #36914: Fix tooltip selector usage
  • #37128: Fix modal event listeners
  • #37146: Drop tabs auto-focus
  • #37151: Fix active class toggling of tabs within dropdown
  • #37189: Enrich Tab Test for keyboard handler
  • #37190: Dropdown: fix case with invalid markup

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/bootstrap-5.2.3 branch from 26b422e to 0ad486a Compare December 3, 2022 03:04
@dependabot dependabot bot requested a review from a team December 3, 2022 03:04
@MichaIng MichaIng added this to the Nextcloud 26 milestone Dec 4, 2022
@MichaIng
Copy link
Member

MichaIng commented Dec 4, 2022

These bootstrap v4 => v5 migration hints will help: https://getbootstrap.com/docs/5.2/migration/

@MichaIng
Copy link
Member

MichaIng commented Dec 4, 2022

/compile amend /

@nextcloud-command nextcloud-command force-pushed the dependabot/npm_and_yarn/bootstrap-5.2.3 branch from 0ad486a to 3939349 Compare December 4, 2022 14:22
@MichaIng MichaIng mentioned this pull request Dec 4, 2022
Closed
@MichaIng
Copy link
Member

MichaIng commented Dec 5, 2022

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/bootstrap-5.2.3 branch from 3939349 to 1285687 Compare December 5, 2022 23:58
@MichaIng
Copy link
Member

MichaIng commented Dec 6, 2022

/compile amend /

@dependabot @nextcloud-command
Bump bootstrap from 4.6.1 to 5.2.3
10666fc 
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.6.1 to 5.2.3.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v4.6.1...v5.2.3)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the dependabot/npm_and_yarn/bootstrap-5.2.3 branch from 1285687 to 10666fc Compare December 6, 2022 00:57
@MichaIng
Copy link
Member

MichaIng commented Dec 6, 2022 •
edited
Loading

Is Bootstrap actually still used anywhere? All compiled JavaScript is identical, as far as I can see, only the asset version parameter has been updated. Probably only made available for apps, and then probably it makes sense to deprecate the global Bootstrap, like jQuery, to be shipped by apps themselves, when the Nextcloud core frameworks are not sufficient/wanted?

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@MichaIng MichaIng modified the milestones: Nextcloud 26, Nextcloud 27 Mar 8, 2023
@skjnldsv
Copy link
Member

Is Bootstrap actually still used anywhere? All compiled JavaScript is identical, as far as I can see, only the asset version parameter has been updated. Probably only made available for apps, and then probably it makes sense to deprecate the global Bootstrap, like jQuery, to be shipped by apps themselves, when the Nextcloud core frameworks are not sufficient/wanted?

Seems like we got rid of it yep!

@skjnldsv
Copy link
Member

#36434

@skjnldsv skjnldsv closed this Apr 15, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 15, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/bootstrap-5.2.3 branch April 15, 2023 07:08
@MichaIng MichaIng removed this from the Nextcloud 27 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaIng @skjnldsv