Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cURL time out #35461

Closed
wants to merge 2 commits into from
Closed

cURL time out #35461

wants to merge 2 commits into from

Conversation

jlssmt
Copy link

@jlssmt jlssmt commented Nov 28, 2022

  • Resolves: --

Summary

Fixed cURL regarding:
https://help.nextcloud.com/t/curl-error-28-operation-timed-out-after-30000-milliseconds-with-0-bytes-received-federated-nextcloud/113088

TODO

--

Checklist

Signed-off-by: jlssmt <42897917+jlssmt@users.noreply.github.com>
Signed-off-by: jlssmt <42897917+jlssmt@users.noreply.github.com>
@szaimen szaimen added the 3. to review Waiting for reviews label Nov 28, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Nov 28, 2022
@szaimen szaimen requested review from a team, ArtificialOwl, skjnldsv and come-nc and removed request for a team November 28, 2022 14:17
@kesselb
Copy link
Contributor

kesselb commented Nov 28, 2022

Reason for 30 seconds: #16972

Afaik, we overwrite the default timeout if necessary, but default should stay 30.

@PVince81
Copy link
Member

would it make sense to make the timeout configurable, specifically for federated shares ?

@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing timeout here does not feel like a good solution.
If the problem only arise for big files there may be a problem with how the connection is handled. It should start recieving data fast even if the file is big.

This was referenced May 3, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@nicoduck
Copy link

nicoduck commented Sep 3, 2023

Since this currently affects me with downloading a big file from a federated share, I'd like to see that as a configuration option.

@kesselb
Copy link
Contributor

kesselb commented Sep 4, 2023

Fixed by #38292

@kesselb kesselb closed this Sep 4, 2023
@kesselb
Copy link
Contributor

kesselb commented Sep 4, 2023

OCA\Files_Sharing\External\Storage extends OC\Files\Storage\DAV.

Therefore, the value of davstorage.request_timeout apply.

There are additional HTTP requests in OCA\Files_Sharing\External\Storage.getShareInfo and OCA\Files_Sharing\External\Storage.getShareInfo.testRemoteUrl not using the parent class timeouts. If someone runs into timeouts, feel free to send another pull request and adjust private $timeout to protected $timeout and use them in the child class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants