Skip to content

Place <h1> into main content #35147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2022
Merged

Place <h1> into main content #35147

merged 1 commit into from
Nov 15, 2022

Conversation

@JuliaKirschenheuter
Copy link
Contributor

Fixes #35138

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Nov 14, 2022
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Nov 14, 2022
Pytal
Pytal approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seems the global styles keeps them in the same positions

ChristophWurst
ChristophWurst approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good

@szaimen
Copy link
Contributor

szaimen commented Nov 15, 2022

/rebase

@ChristophWurst
Copy link
Member

I just restarted Drone. The rebase is not necessary.

@JuliaKirschenheuter @szaimen
Place <h1> into main content
a8ff2ff 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the fix/fix-33741-h1_should_instead_be_in_the_app_content branch from 48bb1c0 to a8ff2ff Compare November 15, 2022 10:50
@szaimen
Copy link
Contributor

szaimen commented Nov 15, 2022

I just restarted Drone. The rebase is not necessary.

Sorry

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 15, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Nov 15, 2022
@szaimen
Copy link
Contributor

szaimen commented Nov 15, 2022

/backport to stable25

@ChristophWurst
Copy link
Member

Sharing integration test failure unrelated.

@ChristophWurst ChristophWurst merged commit 102617f into master Nov 15, 2022
@ChristophWurst ChristophWurst deleted the fix/fix-33741-h1_should_instead_be_in_the_app_content branch November 15, 2022 15:14
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@ChristophWurst ChristophWurst mentioned this pull request Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Pytal Pytal Pytal approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

h1 should instead be in the app content, ideally displayed visually

5 participants

@JuliaKirschenheuter @szaimen @ChristophWurst @Pytal