Skip to content

Mark more config values as sensitive #35096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2022
Merged

Mark more config values as sensitive #35096

merged 1 commit into from
Nov 14, 2022

Conversation

@nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen
Mark more config values as sensitive
663cf04 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Nov 11, 2022
@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Nov 11, 2022
@nickvergessen nickvergessen requested review from a team, ArtificialOwl and blizzz November 11, 2022 08:03
@nickvergessen nickvergessen self-assigned this Nov 11, 2022
@nickvergessen nickvergessen requested review from come-nc and removed request for a team November 11, 2022 08:03
@szaimen szaimen merged commit 98543b1 into master Nov 14, 2022
@szaimen szaimen deleted the bugfix/noid/mark-more-values-as-sensitive branch November 14, 2022 08:45
@blizzz
Copy link
Member

blizzz commented Nov 14, 2022

Should be done on app side via $context->registerSensitiveMethods, e.g. nextcloud/sharepoint#143

@nickvergessen
Copy link
Member Author

Should be done on app side via

We can do that going forward, but we also need to backport this one 🙈

@nickvergessen
Copy link
Member Author

/backport to stable25

@nickvergessen
Copy link
Member Author

/backport to stable24

@nickvergessen
Copy link
Member Author

/backport to stable23

@nickvergessen
Copy link
Member Author

Should be done on app side via $context->registerSensitiveMethods, e.g

Wait, that is about methods. Not about the system report / config list. While still good and mostlikely related it's a different thing.
Will queue a task to check if both are properly documented and then suggest a dev news update with it.

@blizzz
Copy link
Member

blizzz commented Nov 14, 2022

Should be done on app side via $context->registerSensitiveMethods, e.g

Wait, that is about methods. Not about the system report / config list. While still good and mostlikely related it's a different thing. Will queue a task to check if both are properly documented and then suggest a dev news update with it.

Good point, didn't realize it (need more coffee). Probably need to add support to register var names.

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@nickvergessen
Copy link
Member Author

/backport to stable25

@nickvergessen
Copy link
Member Author

/backport to stable24

@nickvergessen
Copy link
Member Author

/backport to stable23

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

This was referenced Nov 16, 2022
Merged
Merged
Merged
@nickvergessen
Copy link
Member Author

Manual backports above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szaimen szaimen szaimen approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @blizzz @szaimen @come-nc