[stable25] Fix HTML entities not decoded in comment just added #35085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/compile amend / |
nextcloud-command
force-pushed
the
backport/35054/stable25
branch
from
7442f56 to
38088e4
Compare
blizzz
requested review from
a team,
PVince81,
Pytal and
szaimen
and removed request for
a team
|
Conflicts... |
Pytal
approved these changes
Nov 23, 2022
|
/compile amend / |
nextcloud-command
force-pushed
the
backport/35054/stable25
branch
from
38088e4 to
1f6239c
Compare
This will make possible to use it from files other than "GetComments.js". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The XML data received from the comments endpoint has an inconsistent encoding; some entities are encoded once and others are encoded twice. When the comment list is loaded the comments are fetched using GetComments, which handles all that, and therefore shows the messages and author names as expected. However, when a new comment is posted the list is not got again; instead the new comment is loaded from the comment data returned after posting it. This is done in NewComment, which did not decode the messages nor the author names, and therefore showed, for example, "&" instead of "&". To solve that now the same decoding logic used in GetComments is applied too in NewComment. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Pytal
force-pushed
the
backport/35054/stable25
branch
from
1f6239c to
aca699c
Compare
|
Rebased + recompiled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backport had conflicts and is incompletebackport of #35054