Skip to content

set theming app to alwaysEnabled #34609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

set theming app to alwaysEnabled #34609

merged 1 commit into from
Oct 18, 2022

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Oct 14, 2022 •
edited
Loading

Close #34338

Disclaimer: I didn't test yet what happens if you disable the app and upgrade to this branch.

Signed-off-by: szaimen szaimen@e.mail.de

@szaimen szaimen added the 2. developing Work in progress label Oct 14, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Oct 14, 2022
@szaimen szaimen requested a review from nickvergessen October 14, 2022 13:26
@szaimen szaimen mentioned this pull request Oct 14, 2022
Closed
9 tasks
@skjnldsv
Copy link
Member

skjnldsv commented Oct 14, 2022 •
edited
Loading

Should be done alongside #34576
So the admin have a way to disable (user) theming to some extend

@szaimen
Copy link
Contributor Author

szaimen commented Oct 14, 2022

Should be done alongside #34576 So the admin have a way to disable (user) theming to some extend

All right! Then 25.0.1 it is?

@szaimen szaimen force-pushed the enh/noid/always-enable-theming branch from 7a3ae88 to 6a13ac0 Compare October 17, 2022 14:38
nickvergessen
nickvergessen reviewed Oct 17, 2022
View reviewed changes
@szaimen szaimen force-pushed the enh/noid/always-enable-theming branch from 6a13ac0 to 3938668 Compare October 17, 2022 14:40
@szaimen
set theming app to alwaysEnabled
1d17a08 
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/always-enable-theming branch from 3938668 to 1d17a08 Compare October 17, 2022 15:51
@szaimen szaimen marked this pull request as ready for review October 17, 2022 19:10
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 17, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Oct 17, 2022 •
edited
Loading

/backport to stable25

@blizzz blizzz merged commit d293324 into master Oct 18, 2022
@blizzz blizzz deleted the enh/noid/always-enable-theming branch October 18, 2022 08:13
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 18, 2022
Merged
@joshtrichards joshtrichards mentioned this pull request Oct 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz blizzz approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

[Bug]: NC25 not working with disabled Theming app

5 participants

@szaimen @skjnldsv @nickvergessen @blizzz