Add admin user customization kill switch#34576
Merged
Conversation
skjnldsv
changed the title
nextcloud-command
force-pushed
the
feat/theming-default-system-value
branch
from
f85b30b to
2f8601a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
changed the title
skjnldsv
requested review from
a team,
CarlSchwan,
GretaD,
PVince81,
Pytal,
artonge and
juliusknorr
and removed request for
a team
skjnldsv
added
3. to review
Member
Author
Yes |
skjnldsv
force-pushed
the
fix/user-theming-admin-overrride
branch
from
f710c71 to
7b79a60
Compare
szaimen
approved these changes
Oct 18, 2022
Contributor
There was a problem hiding this comment.
works great and fixes all the problems that I found a few days ago. (but didnt review the code)
The only problem that I found is this one (it shows the primary background when changing user theming all over the screen which is really disturbing) but not a blocker imho:
2022-10-18-194033.mp4
Pytal
approved these changes
Oct 18, 2022
Pytal
reviewed
Oct 18, 2022
9 tasks
skjnldsv
force-pushed
the
fix/user-theming-admin-overrride
branch
from
7b79a60 to
0026b38
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
added
4. to release
skjnldsv
force-pushed
the
fix/user-theming-admin-overrride
branch
from
0026b38 to
d89da9b
Compare
1 task
Member
|
/backport to stable25 |
1 task
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(ignore the missing icons sometimes, the chromium screenshot tool bugged)
Fix #34561