fix public view #34331
Merged
fix public view #34331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
force-pushed
the
enh/noid/public-view-fix
branch
2 times, most recently
from
f781f1d to
477b9a6
Compare
szaimen
requested review from
a team,
PVince81,
artonge,
juliusknorr and
skjnldsv
and removed request for
a team
szaimen
added
3. to review
szaimen
force-pushed
the
enh/noid/public-view-fix
branch
from
2ec9f86 to
c2b005f
Compare
Signed-off-by: szaimen <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/public-view-fix
branch
from
c2b005f to
25ef2d1
Compare
|
/compile amend / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
enh/noid/public-view-fix
branch
from
25ef2d1 to
e7bd935
Compare
|
/backport to stable25 |
st3iny
approved these changes
Oct 1, 2022
szaimen
requested review from
danxuliu and
max-nextcloud
and removed request for
danxuliu
skjnldsv
approved these changes
Oct 1, 2022
This was referenced Oct 3, 2022
|
This seems to have caused a regression on the public page:
|
|
Can you describe in words what the regression is? |
|
Ah, I see |
|
What is strange that it worked in my testing. Do you have the talk app enabled? |
|
Or is this coming from the text app? |
|
Talk is disabled, text is enabled, but also happens on image/folder shares. Pushed a possible fix for it with #34396 but I'm unsure about the original reasoning for switching to sticky with this PR. Maybe you can check that. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #34206
Signed-off-by: szaimen szaimen@e.mail.de