Correctly handle Redis::keys returning false #34328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
come-nc
requested review from
a team,
blizzz,
juliusknorr and
skjnldsv
and removed request for
a team
juliusknorr
approved these changes
Sep 30, 2022
ChristophWurst
approved these changes
Sep 30, 2022
This was referenced Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems a lot of \Redis method can actually return false, so not sure if this is the only case.
Fix #34155
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com