Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup updatenotification #33947

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Cleanup updatenotification #33947

merged 1 commit into from
Sep 15, 2022

Conversation

CarlSchwan
Copy link
Member

  • Port away from jquery inside vue
  • Use modern vue components when possible
  • Fix some readability issues particularly on dark theme
  • Use IInitialState
  • Use php7.4

@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Sep 7, 2022
@CarlSchwan CarlSchwan requested a review from a team September 7, 2022 16:07
@CarlSchwan CarlSchwan self-assigned this Sep 7, 2022
@CarlSchwan CarlSchwan requested review from PVince81, artonge and skjnldsv and removed request for a team September 7, 2022 16:07
@blizzz blizzz mentioned this pull request Sep 7, 2022
Merged
@CarlSchwan CarlSchwan force-pushed the updatenotificaiton-cleanup branch 2 times, most recently from b7e9ad9 to 098355c Compare September 8, 2022 08:25
@blizzz blizzz mentioned this pull request Sep 9, 2022
Merged
@szaimen szaimen added the 3. to review Waiting for reviews label Sep 14, 2022
@CarlSchwan
Copy link
Member Author

/compile amend /

@CarlSchwan @nextcloud-command
Cleanup updatenotification
7bd83d9 
- Port away from jquery inside vue
- Use modern vue components when possible
- Fix some readability isssues particularly on dark theme
- Use IInitialState
- Use php7.4

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
come-nc
come-nc approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed backend part, half 🐘 on frontend part

PVince81
PVince81 approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit c0c31bd into master Sep 15, 2022
@PVince81 PVince81 deleted the updatenotificaiton-cleanup branch September 15, 2022 12:12
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
@PVince81 PVince81 mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@come-nc come-nc come-nc approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

@CarlSchwan CarlSchwan

Labels
3. to review Waiting for reviews enhancement technical debt
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
5 participants
@CarlSchwan @PVince81 @skjnldsv @come-nc @szaimen