Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move background settings from dashboard app to Appearance and accessibility settings #33733

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Move background settings from dashboard app to Appearance and accessibility settings #33733

merged 1 commit into from
Sep 14, 2022

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Aug 29, 2022 •
edited by Pytal
Loading

For #33736

Screenshot

image

To Do

@GretaD GretaD added the 2. developing Work in progress label Aug 29, 2022
This was referenced Aug 29, 2022
Closed
Merged
Merged
@jancborchardt jancborchardt mentioned this pull request Sep 1, 2022
Closed
1 task
@Pytal Pytal self-assigned this Sep 6, 2022
@jancborchardt jancborchardt mentioned this pull request Sep 6, 2022
Closed
4 tasks
@Pytal Pytal changed the title Add settings background to theming instead of dashboard Move background settings from dashboard app to Appearance and accessibility settings Sep 8, 2022
@Pytal Pytal force-pushed the change/appearance-accessibility-settings branch from 081b0bb to 6857126 Compare September 8, 2022 02:09
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 8, 2022
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

@Pytal
Copy link
Member

Pytal commented Sep 8, 2022

Taking over and rebased for latest redesign changes

@GretaD GretaD marked this pull request as ready for review September 8, 2022 09:17
@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 14, 2022
@nextcloud-command nextcloud-command force-pushed the change/appearance-accessibility-settings branch from ae277d8 to edd24af Compare September 14, 2022 09:10
@szaimen
Copy link
Contributor

szaimen commented Sep 14, 2022

Conflicts...

@szaimen szaimen added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Sep 14, 2022
@PVince81
Copy link
Member

ok, let me rebase and rebuild...

@PVince81 PVince81 force-pushed the change/appearance-accessibility-settings branch from edd24af to c4fdce1 Compare September 14, 2022 14:35
@PVince81
Copy link
Member

@Pytal was this actually finished ? the label still says "2 to develop", please adjust accordingly and merge if applicable once ready

@szaimen
Copy link
Contributor

szaimen commented Sep 14, 2022

@Pytal was this actually finished ? the label still says "2 to develop", please adjust accordingly and merge if applicable once ready

I added the label. It was finished

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 14, 2022
@szaimen
Copy link
Contributor

szaimen commented Sep 14, 2022

Failing tests seem related

@szaimen szaimen added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Sep 14, 2022
@szaimen szaimen mentioned this pull request Sep 14, 2022
Merged
5 tasks
@Pytal Pytal force-pushed the change/appearance-accessibility-settings branch from c4fdce1 to 2eecbda Compare September 14, 2022 17:55
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 14, 2022
@Pytal Pytal force-pushed the change/appearance-accessibility-settings branch 2 times, most recently from b48b30c to 87fcbc9 Compare September 14, 2022 18:07
@GretaD @Pytal
Move background settings from dashboard app to Appearance and accessi…
02cc42d 
…bility settings

Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the change/appearance-accessibility-settings branch from 87fcbc9 to 02cc42d Compare September 14, 2022 20:17
@szaimen
Copy link
Contributor

szaimen commented Sep 14, 2022

CI failure unrelated

@szaimen szaimen merged commit 009d5e9 into master Sep 14, 2022
@szaimen szaimen deleted the change/appearance-accessibility-settings branch September 14, 2022 22:36
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
@Pytal Pytal mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@GretaD GretaD

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility design Design, UI, UX, etc. feature: accessibility feature: settings feature: theming
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
7 participants
@GretaD @Pytal @PVince81 @szaimen @ChristophWurst @juliushaertl @CarlSchwan