Fix duplicate ids on apps management page #33526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
added
bug
3. to review
Pytal
requested review from
PVince81,
artonge and
skjnldsv
and removed request for
a team
artonge
approved these changes
Aug 17, 2022
|
CI failure unrelated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix duplicate ids on the DOM due to high frequency of collision with the existing logic
Collisions are likely due to both the relatively small bounded range of
Math.floor((Math.random() * 100))and the consecutive invokations ofnew Date().getSeconds() + new Date().getMilliseconds()returning the same value due to the Date objects being instantiated within the same millisecondOld format:
invertIconApps6245357New format:
invertIconApps-1iyigl45bhf