-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't hard error when trying to load profiles with no profiler registered #33292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@icewind1991 please always make sure to have 4-5 reviewers lined up to increase the probability |
7d066bf
to
f01f42c
Compare
…ered Signed-off-by: Robin Appelman <robin@icewind.nl>
if ($this->storage) { | ||
return $this->storage->read($token); | ||
} else { | ||
return null; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ($this->storage) { | |
return $this->storage->read($token); | |
} else { | |
return null; | |
} | |
return $this->storage?->read($token); |
For the record, you can use the nullsafe operator in PHP 8 for this.
instead just return empty results