Skip to content

Use explicit name for new file/folder menu #33271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2022
Merged

Use explicit name for new file/folder menu #33271

merged 1 commit into from
Jul 27, 2022

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Jul 18, 2022

Improve accessibility

@Pytal
Use explicit name for new file/folder menu
7d95678 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 25 milestone Jul 18, 2022
@Pytal Pytal self-assigned this Jul 18, 2022
@github-actions
Copy link
Contributor

Possible performance regression detected

Show Output 
1 queries added

≠ /remote.php/dav/files/test with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/test.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

PVince81
PVince81 approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 1cf6839 into master Jul 27, 2022
@PVince81 PVince81 deleted the enh/a11y-new-file-menu branch July 27, 2022 07:23
@PVince81 PVince81 mentioned this pull request Jul 27, 2022
Closed
7 tasks
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@szaimen szaimen szaimen approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@Pytal Pytal

Labels

3. to review Waiting for reviews feature: accessibility

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

3 participants

@Pytal @PVince81 @szaimen