Run php tests when 3rdparty changed #32813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
debt/noid/check-for-3rdparty-updates
branch
from
16212b7 to
17a12bf
Compare
|
/backport to stable24 |
|
/backport to stable23 |
|
/backport to stable22 |
nickvergessen
approved these changes
Jun 10, 2022
CarlSchwan
approved these changes
Jun 10, 2022
This was referenced Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/drone-run-php-tests.shis there to reduce CI load a bit. The idea to skip for example the php tests when only vue/js is touched. Screenshot below is from a dependency update. As we don't have a check for 3rdparty the php tests are skipped and CI is happy. But we didn't run the unit tests for the dependency update 🙈Example to test the condition:
[[ $(git diff --name-only 51c61d3194a306c68daab34537742f476408cfe3...aee4d39aa974431bbe473829fc44e7084b43e809 | grep -c "3rdparty") -gt 0 ]] && echo "3rdparty is modified";