Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop BackgroundCleanupJob when previews are disabled #32440

Closed
wants to merge 3 commits into from
Closed

Stop BackgroundCleanupJob when previews are disabled #32440

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 16, 2022

Fixes #30793

Stop BackgroundCleanupJob when previews are disabled
cbf91ed 
Signed-off-by: Carl Csaposs <carl@csaposs.com>
ghost
ghost commented May 16, 2022
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first PR so please look at the diff carefully and let me know if there's anything I could improve.

tests/lib/Preview/BackgroundCleanupJobTest.php Outdated Show resolved Hide resolved
tests/lib/Preview/BackgroundCleanupJobTest.php Outdated Show resolved Hide resolved
Add missing property declarations
efc6412 
Signed-off-by: Carl Csaposs <carl@csaposs.com>
@ghost
Copy link
Author

ghost commented May 17, 2022

I noticed there's a CI to block fixup and squash commits--should I rebase (i.e. squash efc6412 into the first commit) and force push?

@szaimen szaimen added enhancement 3. to review Waiting for reviews labels Jun 9, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Jun 9, 2022
@szaimen szaimen requested review from a team, icewind1991, skjnldsv and come-nc and removed request for a team June 9, 2022 13:34
Restore old configuration value after test
1a6aed6 
Signed-off-by: Carl Csaposs <carl@csaposs.com>
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@ghost ghost closed this by deleting the head repository Nov 14, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

Disable BackgroundCleanupJob when previews are disabled
3 participants
@PVince81 @blizzz @szaimen