[stable24] Allow compatibility wrapper on local external storage #32273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check was likely in place to prevent adding the wrapper on the root and home storage, which is not possible anyway since the encoding option cannot be set on that mount. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
backportbot-nextcloud
bot
requested review from
CarlSchwan,
PVince81,
artonge,
come-nc and
icewind1991
Merged
|
missing reviewers, moving to 24.0.2 |
|
moving to 24.0.3… |
Merged
Merged
|
and moving to 24.0.4… @PVince81 please close the PR if it is not necessary, otherwise please find some reviewers. |
Merged
|
@PVince81 this moved pushed already three times. please find reviewers or close this PR if it is not necessary. |
|
@artonge @CarlSchwan @icewind1991 second review please |
come-nc
approved these changes
Aug 4, 2022
|
Samba test is failing, but might be a hiccup:
Restarting the drone job. |
|
Samba is green => merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #32152