don't perform an explicit setup when using the file cache #32163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
come-nc and
vanpertsch
and removed request for
a team
come-nc
approved these changes
Apr 26, 2022
icewind1991
force-pushed
the
file-cache-gc-no-full-setup
branch
from
991349a to
625ed52
Compare
CarlSchwan
reviewed
Apr 28, 2022
icewind1991
force-pushed
the
file-cache-gc-no-full-setup
branch
2 times, most recently
from
0b1b031 to
9d9973c
Compare
Merged
icewind1991
force-pushed
the
file-cache-gc-no-full-setup
branch
from
9d9973c to
f319a04
Compare
Merged
icewind1991
force-pushed
the
file-cache-gc-no-full-setup
branch
from
f319a04 to
2332aa8
Compare
Merged
|
conflicts is this still relevant @icewind1991 ? |
Merged
Merged
Merged
Merged
skjnldsv
added
2. developing
|
Conflicts are a bit too big for me to rebase 🙈 |
icewind1991
force-pushed
the
file-cache-gc-no-full-setup
branch
2 times, most recently
from
ab70350 to
247e347
Compare
the automated partial setup does it's job already Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
file-cache-gc-no-full-setup
branch
from
247e347 to
4fba4cd
Compare
icewind1991
added
3. to review
skjnldsv
approved these changes
Mar 7, 2024
|
This breaks the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the automated partial setup does it's job already
This is mainly noticeable for requests that trigger a login (such as basic auth api requests) as they trigger the file cache gc.