improve query to detect shared mountpoint in folder #32028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
approved these changes
Apr 20, 2022
|
conflicts, and need to check if compatible with new NC 24 FS code |
Merged
|
@icewind1991 please resolve conflict |
|
is it covered by unit tests ? |
Merged
Merged
Merged
Merged
Merged
|
conflicts |
szaimen
added
2. developing
Merged
|
abandoned? |
Merged
|
Conflicts are a bit too big for me to rebase 🙈 |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
share-mount-check-no-in
branch
from
83417a6
to
e304a2e
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
|
Closing this pull request due to lack of recent activity and updates. We appreciate your contribution and encourage you to reopen or provide further updates if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in #31610, the logic to find shared mountpoints in a folder relies on a
INexpression which doesn't scale past 1000 items with oracle.This changes the logic to not require any
IN, it does require loading more results from the database though as there is no proper way to filter a path only for direct children in sql.