Skip to content

Improve performance dav PROPFIND #31843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 6, 2022
Merged

Improve performance dav PROPFIND #31843

merged 4 commits into from
Apr 6, 2022

Conversation

icewind1991
Copy link
Member

  • Allow reusing known folder info when getting directory content
  • Reuse known fileinfo to get the filesystem node for each dav node
  • Use known filesystem node from above in SharesPlugin instead of re-querying

Saves 4 queries for each propfind in my testing

@icewind1991 icewind1991 added this to the Nextcloud 24 milestone Apr 5, 2022
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, come-nc and skjnldsv and removed request for a team April 5, 2022 13:40
come-nc
come-nc approved these changes Apr 5, 2022
View reviewed changes
skjnldsv
skjnldsv reviewed Apr 5, 2022
View reviewed changes
@skjnldsv
Copy link
Member

skjnldsv commented Apr 6, 2022

Needs a rebase and we're good! 🚀

@icewind1991 icewind1991 force-pushed the dav-plugin-perf branch 2 times, most recently from 86dcd4f to f8a00c7 Compare April 6, 2022 12:08
@icewind1991
save filesystem node in dav node
9b1abd6 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
allow reusing known folder info when getting directory contents
151c800 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
use existing node in SharesPlugin
ae7205f 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
sh
5e69f98 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 merged commit 9f34d17 into master Apr 6, 2022
@icewind1991 icewind1991 deleted the dav-plugin-perf branch April 6, 2022 16:49
@blizzz blizzz mentioned this pull request Apr 7, 2022
Merged
@danxuliu danxuliu mentioned this pull request Aug 8, 2022
Closed
@joshtrichards joshtrichards mentioned this pull request Aug 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees

No one assigned

Labels

3. to review Waiting for reviews performance 🚀

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991 @skjnldsv @come-nc