Rename setting 'sendEventRemindersToSharedGroupMembers' -> 'sendEventRemindersToSharedUsers'.

[dzatoah]

@tcitworld #31337 (comment):

Of course I forgot to say we should rename sendEventRemindersToSharedGroupMembers to sendEventRemindersToSharedUsers, as the share can be done with groups as well as direct users.

[dzatoah]

In which Nextcloud version will this feature come later?

[ChristophWurst]

24

[szaimen]

Hi @dzatoah can you please fix the conflicts so that we can merge this? Thanks in advance! :)

[dzatoah]

Thanks, @szaimen. I was confused af for a moment there...

[ChristophWurst]

@dzatoah @szaimen what's the upgrade path? If this went into 24 it would be fine but now there is a good chance there are instances with a setting for sendEventRemindersToSharedGroupMembers. We have to migrate the old setting over to the new name.

[szaimen]

@dzatoah would you be up for creating the migration from the old to the new setting? :)

[dzatoah]

I'm sorry, but I have to decline.

[szaimen]

I see.

So what then @ChristophWurst? Revert?

[dzatoah]

How would you estimate the effort? Is this doable for a Nextcloud newbie?

[ChristophWurst]

This could be done with a repair step that reads any old value and write it under the new name. Repair steps look like this: https://github.com/nextcloud/server/blob/master/lib/private/Repair/OldGroupMembershipShares.php.

[ChristophWurst]

The repair step would belong to the dav app, so maybe https://github.com/nextcloud/server/blob/master/apps/dav/lib/Migration/RemoveObjectProperties.php is better example. The step is then registered in

server/apps/dav/appinfo/info.xml

Lines 30 to 43 in a1ed1db

	<repair-steps>
	<post-migration>
	<step>OCA\DAV\Migration\FixBirthdayCalendarComponent</step>
	<step>OCA\DAV\Migration\RegenerateBirthdayCalendars</step>
	<step>OCA\DAV\Migration\CalDAVRemoveEmptyValue</step>
	<step>OCA\DAV\Migration\BuildCalendarSearchIndex</step>
	<step>OCA\DAV\Migration\BuildSocialSearchIndex</step>
	<step>OCA\DAV\Migration\RefreshWebcalJobRegistrar</step>
	<step>OCA\DAV\Migration\RegisterBuildReminderIndexBackgroundJob</step>
	<step>OCA\DAV\Migration\RemoveOrphanEventsAndContacts</step>
	<step>OCA\DAV\Migration\RemoveClassifiedEventActivity</step>
	<step>OCA\DAV\Migration\RemoveDeletedUsersCalendarSubscriptions</step>
	<step>OCA\DAV\Migration\RemoveObjectProperties</step>
	</post-migration>

[ChristophWurst]

@szaimen please revert this change

[szaimen]

Done in #38177