Skip to content

Increase loglevel of Webcal parsing errors and modernize code #31622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2022
Merged

Increase loglevel of Webcal parsing errors and modernize code #31622

merged 1 commit into from
Jun 10, 2022

Conversation

@tcitworld
Copy link
Member

Closes #31612

If backports have to be made, they need to be done manually (some specific PHP 7.4+ code in there)

@tcitworld tcitworld added bug 3. to review Waiting for reviews php Pull requests that update Php code feature: caldav Related to CalDAV internals labels Mar 18, 2022
@tcitworld tcitworld added this to the Nextcloud 24 milestone Mar 18, 2022
@tcitworld tcitworld requested review from a team and nickvergessen March 18, 2022 17:10
miaulalala
miaulalala approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice-nice
!

This was referenced Mar 21, 2022
Closed
Closed
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
This was referenced Apr 7, 2022
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@come-nc
Copy link
Contributor

come-nc commented May 5, 2022

@tcitworld Rebase needed because of conflicts

@tcitworld tcitworld force-pushed the increase-loglevel-modernize-refresh-webcal branch from 2c7a883 to 41f0b07 Compare May 12, 2022 16:14
tcitworld
tcitworld commented May 12, 2022
View reviewed changes
@tcitworld
Copy link
Member Author

Rebased.

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 13, 2022
@ChristophWurst
Copy link
Member

Drone restarted because it ran into timeouts

@tcitworld tcitworld force-pushed the increase-loglevel-modernize-refresh-webcal branch from 41f0b07 to 5f9d64a Compare May 13, 2022 08:40
@ChristophWurst

This comment was marked as resolved.

Sign in to view
@tcitworld tcitworld force-pushed the increase-loglevel-modernize-refresh-webcal branch 2 times, most recently from 078e0bc to 2e20227 Compare May 13, 2022 09:33
@tcitworld
Increase loglevel of Webcal parsing errors and modernize code
741c443 
Closes #31612

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the increase-loglevel-modernize-refresh-webcal branch from 2e20227 to 741c443 Compare May 17, 2022 13:12
@PVince81 PVince81 merged commit 5f8e1b7 into master Jun 10, 2022
@PVince81 PVince81 deleted the increase-loglevel-modernize-refresh-webcal branch June 10, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes

@come-nc come-nc come-nc approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals php Pull requests that update Php code

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

Increase the loglevel of errors reported when parsing calendar subscriptions

7 participants

@tcitworld @come-nc @ChristophWurst @nickvergessen @miaulalala @PVince81 @blizzz