Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Mar 3, 2022

The implementations return either ISimpleFile or InMemoryFile

  • /**
    * Returns the avatar for an user.
    *
    * If there is no avatar file yet, one is generated.
    *
    * @param int $size
    * @return ISimpleFile
    * @throws NotFoundException
    * @throws \OCP\Files\NotPermittedException
    * @throws \OCP\PreConditionNotMetException
    */
    public function getFile($size) {
  • /**
    * Returns the avatar for an user.
    *
    * If there is no avatar file yet, one is generated.
    *
    * @param int $size
    * @return ISimpleFile
    * @throws NotFoundException
    * @throws \OCP\Files\NotPermittedException
    * @throws \OCP\PreConditionNotMetException
    */
    public function getFile($size) {
  • /**
    * Generates an avatar for the guest.
    *
    * @param int $size The desired image size.
    * @return InMemoryFile
    */

@Pytal Pytal added bug 3. to review Waiting for reviews labels Mar 3, 2022
@Pytal Pytal added this to the Nextcloud 24 milestone Mar 3, 2022
@Pytal Pytal requested review from a team and come-nc March 3, 2022 04:47
@Pytal Pytal self-assigned this Mar 3, 2022
@Pytal Pytal requested review from ArtificialOwl and PVince81 and removed request for a team March 3, 2022 04:47
@Pytal Pytal force-pushed the fix/avatar-return-type branch from 3559b36 to 61a9d7d Compare March 3, 2022 05:08
@Pytal Pytal mentioned this pull request Mar 3, 2022
5 tasks
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the change already mentioned by @come-nc

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/avatar-return-type branch from 61a9d7d to 31a9be0 Compare March 3, 2022 16:07
@Pytal Pytal requested a review from come-nc March 3, 2022 16:07
@Pytal
Copy link
Member Author

Pytal commented Mar 3, 2022

/backport to stable23

@Pytal
Copy link
Member Author

Pytal commented Mar 3, 2022

/backport to stable22

@Pytal
Copy link
Member Author

Pytal commented Mar 3, 2022

/backport to stable21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants