Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 11, 2022

Backport of #30945

@nickvergessen nickvergessen added the 2. developing Work in progress label Feb 11, 2022
@nickvergessen nickvergessen added this to the Nextcloud 22.2.5 milestone Feb 11, 2022
@blizzz blizzz mentioned this pull request Feb 11, 2022
12 tasks
@PVince81
Copy link
Member

PVince81 commented Feb 18, 2022

what bits are missing to finish this ?

also to not forget:

  • port to stable23 (in case there were conflicts resolved here)

@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 18, 2022

what bits are missing to finish this ?

  • Wait for master to be merged
  • Make sure the Patch is still up to date in case master was modified
  • Trigger backport bot from master for 23 (optional: close this and backport bot to 22 as well)

@nickvergessen nickvergessen marked this pull request as ready for review February 22, 2022 10:55
@nickvergessen nickvergessen added 3. to review Waiting for reviews feature: settings and removed 2. developing Work in progress labels Feb 22, 2022
Signed-off-by: Joas Schilling <coding@schilljs.com>
… run

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the backport/30945/stable22 branch from 490c8c0 to 714a5b7 Compare February 22, 2022 10:56
@blizzz blizzz mentioned this pull request Mar 9, 2022
@nickvergessen nickvergessen requested review from a team and removed request for a team and ChristophWurst March 9, 2022 13:56
@nickvergessen
Copy link
Member Author

Review please

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen requested a review from blizzz March 10, 2022 12:47
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 10, 2022
@blizzz blizzz merged commit da4cd47 into stable22 Mar 10, 2022
@blizzz blizzz deleted the backport/30945/stable22 branch March 10, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: settings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants