Support npm 7 when running autotest-js.sh #30718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
changed the title
artonge
changed the title
artonge
force-pushed
the
tests/use_npm7_for_autotest-js
branch
from
6dc693e to
71a9f33
Compare
artonge
changed the title
artonge
force-pushed
the
tests/use_npm7_for_autotest-js
branch
from
71a9f33 to
65db550
Compare
artonge
force-pushed
the
tests/use_npm7_for_autotest-js
branch
from
65db550 to
f879894
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
tests/use_npm7_for_autotest-js
branch
2 times, most recently
from
d9cfb2f to
50457a6
Compare
artonge
added
3. to review
artonge
force-pushed
the
tests/use_npm7_for_autotest-js
branch
2 times, most recently
from
deff676 to
c53d61d
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
tests/use_npm7_for_autotest-js
branch
from
c53d61d to
bca3ef6
Compare
artonge
requested review from
a team,
PVince81,
skjnldsv and
szaimen
and removed request for
a team
|
CI failure unrelated. |
artonge
changed the title
skjnldsv
approved these changes
Jan 18, 2022
This was referenced Jan 18, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm@7to runautotest-js.shjsunitdependencies to the mainpackage.json.contactmenutests that should be failing but were not. Long story short, I have no idea why they were not failing and are failing now, but I fixed the tests to match reality. I think it has to do with thescssfiles not being compiled correctly for some time and fixing the compilation, but I have no idea why it could be linked to the failing tests.Anyway,
scssfile are now compiling, tests are passing, we have onenode_moduleless to manage, and we do not have to switch between npm 6 and 7 when investigating failing tests. 🎉