Fix fail when keys/files folder already exists #30565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with transfer ownership in move mode where the folder "files_encryption/keys/files" already exists. Instead of failing, its existence is checked before calling mkdir. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
added
bug
3. to review
PVince81
requested review from
CarlSchwan,
artonge,
icewind1991 and
julien-nc
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
CarlSchwan
approved these changes
Jan 10, 2022
CarlSchwan
reviewed
Jan 10, 2022
|
JS failure unrelated, merging |
PVince81
deleted the
bugfix/30564/fix-mkdir-fail-when-keys-folder-exists
branch
This was referenced Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with transfer ownership in move mode where the folder
"files_encryption/keys/files" already exists.
Instead of failing, its existence is checked before calling mkdir.
Fixes #30564
Note: normally the target folders don't exist yet when doing a copy over webdav because the webdav code (or higher layers) will first delete the target before starting the copy. With transfer ownership we operate on a different layer so this pre-deletion is not done but there's a check upfront that the target storage is empty.