Make all CalDAV PHP classes strict #30437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
miaulalala and
tcitworld
as code owners
7 tasks
Fixed via #30438 (extracted so we can backport) |
miaulalala
approved these changes
Jan 3, 2022
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Ref sabre-io/vobject#560 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
techdebt/strict-caldav-classes
branch
from
3463575 to
83ce6cf
Compare
Merged
Merged
|
stale |
|
But still useful, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref nextcloud/groupware#17
This caught a previously implicit cast from a Sabre parameter to a string. Upstream code was annotated so our tools can detect this earlier next time: sabre-io/vobject#560