Skip to content

improve status modal #30420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2021
Merged

improve status modal #30420

merged 1 commit into from
Dec 30, 2021

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Dec 28, 2021 •
edited
Loading

Before After
image image

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e SERVER_BRANCH=enh/noid/improve-status-modal \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 24 milestone Dec 28, 2021
@szaimen szaimen force-pushed the enh/noid/improve-status-modal branch 3 times, most recently from 18d9ff8 to ff74edf Compare December 28, 2021 11:55
@nextcloud-command nextcloud-command force-pushed the enh/noid/improve-status-modal branch from ff74edf to 523547d Compare December 28, 2021 12:07
@szaimen szaimen force-pushed the enh/noid/improve-status-modal branch from 523547d to d6a0ba9 Compare December 28, 2021 12:10
@nextcloud-command nextcloud-command force-pushed the enh/noid/improve-status-modal branch from d6a0ba9 to 3e29509 Compare December 28, 2021 12:26
@szaimen
Copy link
Contributor Author

szaimen commented Dec 30, 2021

/compile amend /

@szaimen szaimen force-pushed the enh/noid/improve-status-modal branch from 3e29509 to 7bb8091 Compare December 30, 2021 12:18
@szaimen @nextcloud-command
improve status modal
3c9b6f6 
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/noid/improve-status-modal branch from 7bb8091 to 3c9b6f6 Compare December 30, 2021 12:25
@szaimen szaimen marked this pull request as ready for review December 30, 2021 12:38
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 30, 2021
@szaimen szaimen requested review from a team, PVince81, Pytal, artonge, jancborchardt and nimishavijay and removed request for a team December 30, 2021 12:38
jancborchardt
jancborchardt approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice, looks much better!

@szaimen
Copy link
Contributor Author

szaimen commented Dec 30, 2021

⚙ failure unrelated

@szaimen szaimen merged commit adedb29 into master Dec 30, 2021
@szaimen szaimen deleted the enh/noid/improve-status-modal branch December 30, 2021 18:14
@szaimen
Copy link
Contributor Author

szaimen commented Dec 30, 2021

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Dec 30, 2021

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Dec 30, 2021

/backport to stable21

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 30, 2021
Merged
This was referenced Dec 30, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@artonge artonge artonge approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@PVince81 PVince81 Awaiting requested review from PVince81

@Pytal Pytal Awaiting requested review from Pytal

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: status

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

4 participants

@szaimen @jancborchardt @artonge