Add missing index for propertypath only queries of DAV properties #30392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
2. developing
ChristophWurst
commented
Dec 23, 2021
ChristophWurst
added
3. to review
|
/backport to stable23 |
|
/backport to stable22 |
ChristophWurst
changed the title
tcitworld
approved these changes
Dec 23, 2021
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
4. to release
ChristophWurst
force-pushed
the
fix/missing-properties-propertypath-index
branch
from
681e52f to
ed84f07
Compare
juliusknorr
approved these changes
Dec 28, 2021
|
Psalm failure unrelated. |
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
|
Backports failed. 😢 |
|
Weird. It works just fine locally. |
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
This was referenced Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a performance regression of #27426.
All other queries of this class select rows by their
propertypathanduserid, so the index from #20716 is used. The new query only selects bypropertypath, therefore the old index did not apply.Todo
How to test
Run
EXPLAIN SELECT * FROM `oc_properties` WHERE `propertypath` = 'calendars/admin/inbox';on mariadb/mysql or the equivalent for any other DB before/after applying the optional index. Before no index used. Afterwards it uses an index.