[stable23] Fix share owner not being displayed in sharing tab#30315
Merged
[stable23] Fix share owner not being displayed in sharing tab#30315
Conversation
backportbot-nextcloud
bot
requested review from
CarlSchwan,
PVince81,
Pytal,
artonge and
skjnldsv
Member
|
/compile amend |
This only concerns subfolder and files inside a shared folder and is used as fallback when the OCS api returns a empty result, because it only works on the shared folder and not the content inside of it. This unify the tab with the folder list. This offers a less descriptive share information but making the OCS api returns all the details even for the subfolder would very probably be bad for performance (since we would need to fetch the shares for all the parent folders until we found one or are in the root folder). Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
backport/30266/stable23
branch
from
0a3fbf1 to
2b7bee1
Compare
CarlSchwan
approved these changes
Dec 17, 2021
skjnldsv
approved these changes
Dec 21, 2021
Contributor
|
Backport seem complete and CI failure is unrelated, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #30266