[stable22] Fix input for groups validation in new user form #30145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
PVince81,
artonge,
danxuliu,
juliusknorr and
skjnldsv
The hidden input used for form validation was not actually hidden since Nextcloud 22, as the DOM structure changed to show a dialog rather than adding a row on top of the list when adding new users, so the CSS rules no longer matched. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Since Nextcloud 22 the "#new-user" rules had no effect, as the DOM structure changed to show a dialog rather than adding a row on top of the list when adding new users. Similarly, the z-index was no longer needed, as there will be no "new-user" row that could overlap. Moreover, the z-index was set even higher (100) in another rule still active. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
backport/29968/stable22
branch
from
ea24c9e to
bf499c0
Compare
danxuliu
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Tested and works 👍
jsunit test failures are unrelated to this pull request, see for example https://github.com/nextcloud/server/runs/4445590430
skjnldsv
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #29968