Skip to content

Add option to disallow creation of local storages #30111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2021
Merged

Add option to disallow creation of local storages #30111

merged 1 commit into from
Dec 16, 2021

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Dec 6, 2021 •
edited by szaimen
Loading

Introduce a new config option to prevent web UI admins to create
or edit external storages of type "local".

Fixes #29973

  • TEST: occ command can create
  • TEST: cannot create local storages in web UI
  • TEST: existing local storages appear grey in web UI
  • TEST: test when allowed

⚠️ this will change the default, by default "Local" will not be visible so one needs to enable it where needed

Inspired from:

@PVince81 PVince81 self-assigned this Dec 6, 2021
@PVince81 PVince81 mentioned this pull request Dec 6, 2021
Closed
@szaimen szaimen added this to the Nextcloud 24 milestone Dec 6, 2021
@szaimen szaimen mentioned this pull request Dec 6, 2021
Closed
@PVince81
Copy link
Member Author

PVince81 commented Dec 6, 2021

I need to fix some tests:


1) OCA\Files_External\Tests\Controller\GlobalStoragesControllerTest::testAddStorage
--


ArgumentCountError:
 Too few arguments to function 
OCA\Files_External\Controller\GlobalStoragesController::__construct(), 7
 passed in 
/drone/src/apps/files_external/tests/Controller/GlobalStoragesControllerTest.php
 on line 59 and exactly 8 expected

@PVince81 PVince81 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 6, 2021
@PVince81 PVince81 force-pushed the enh/29973/option-disallow-local-storage branch from 6c7f46d to 9ccf011 Compare December 6, 2021 16:55
@PVince81 PVince81 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 6, 2021
@PVince81
Copy link
Member Author

PVince81 commented Dec 6, 2021

build is passing now, please review

miaulalala
miaulalala approved these changes Dec 6, 2021
View reviewed changes
artonge
artonge requested changes Dec 7, 2021
View reviewed changes
@PVince81
Add option to disallow creation of local storages
ea30297 
Introduce a new config option to prevent web UI admins to create
or edit external storages of type "local".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the enh/29973/option-disallow-local-storage branch from ba72fc9 to ea30297 Compare December 15, 2021 08:23
@PVince81
Copy link
Member Author

fixed the readOnly var, I replaced it with an inline statement now as it was used only in one location
and removed console.log and redid a quick test

@PVince81 PVince81 requested review from artonge and removed request for icewind1991 December 15, 2021 08:25
@PVince81 PVince81 merged commit 6c424fb into master Dec 16, 2021
@PVince81 PVince81 deleted the enh/29973/option-disallow-local-storage branch December 16, 2021 10:12
@icewind1991
Copy link
Member

/backport to stable23

@icewind1991
Copy link
Member

/backport to stable22

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 7, 2022
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@miaulalala miaulalala miaulalala approved these changes

@szaimen szaimen Awaiting requested review from szaimen

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@PVince81 PVince81

Labels

3. to review Waiting for reviews enhancement feature: external storage

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

Disallow creation of "local" storage for web UI admins

6 participants

@PVince81 @icewind1991 @artonge @miaulalala @szaimen