list.php files are only invoked via ViewController and APIController #30024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of them actually check that the user is logged in before and also the list.php files themselves would break with getUserSession()->getUser()->getUID() which they contain. Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
icewind1991,
ChristophWurst,
blizzz,
skjnldsv and
CarlSchwan
skjnldsv
approved these changes
Dec 1, 2021
CarlSchwan
approved these changes
Dec 1, 2021
nickvergessen
added
4. to release
blizzz
approved these changes
Dec 1, 2021
nickvergessen
deleted the
techdebt/noid/list-php-are-only-invokable-via-controllers
branch
|
/backport to stable23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of them actually check that the user is logged in before
and also the list.php files themselves would break with
getUserSession()->getUser()->getUID() which they contain.