Let repair step query exceptions bubble up #29974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
a team,
miaulalala,
st3iny and
tcitworld
ChristophWurst
requested review from
come-nc,
icewind1991 and
nickvergessen
and removed request for
a team
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
And hide the type error caused by a constructor call with missing arguments. `new $repairStep();` only works for the rare case that no arguments are required. Anything else will throw. Then we previously hid the trace of the more important query exception. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/repair-step-query-exception-bubble
branch
from
f125e12 to
f68ab00
Compare
come-nc
approved these changes
Nov 30, 2021
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
nickvergessen
approved these changes
Nov 30, 2021
miaulalala
approved these changes
Nov 30, 2021
This was referenced Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And hide the type error caused by a constructor call with missing
arguments.
new $repairStep();only works for the rare case that no arguments arerequired. Anything else will throw. Then we previously hid the trace of
the more important query exception.
This will help debug bugs like nextcloud/mail#5755.